[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

> The way `Enable()/Disable()` is currently implemented will not work when the tool executes jobs in parallel (ie. llvm-buildozer <https://www.youtube.com/watch?v=usPL_DROn4k> I presented at LLVM conference; or our re-implementation of /MP <https://docs.microsoft.com/en-us/cpp/build/reference/mp-build-with-multiple-processes?view=vs-2019> which I haven't published yet). It needs refcounting, otherwise one instance might disable the CRC while other threads are running, which effectively disables the crash handlers.
>  But we can discuss that in a separate review if you prefer. I'll remove it from this patch unless you say otherwise.

Yes, I think it would be good to deal with that separately, to allow for incremental progress.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70568/new/

https://reviews.llvm.org/D70568