[PATCH] D70570: [PowerPC] Only use PLT annotations if using PIC relocation model

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 06:05:23 PST 2019


sfertile accepted this revision as: sfertile.
sfertile added a comment.

LGTM also. I have one minor question: Is it worthwhile to add a small lit test  explicitly for this?  ie.

1. we don't emit the '@PLT' annotation on a call when linking with static-relocation model.
2. emit the annotation with PIC relocation model.

That gives us somewhere a bit more visible you can add the comment about how emitting the annotation for static relocation model breaks secure-plt linking with ld.bfd.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70570/new/

https://reviews.llvm.org/D70570





More information about the llvm-commits mailing list