[PATCH] D71631: [ELF] writePlt: replace parameters gotPltEntryAddr and index with `const Symbol &`. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 00:17:31 PST 2019


MaskRay added inline comments.


================
Comment at: lld/ELF/Arch/Mips.cpp:323
+                          uint64_t pltEntryAddr) const {
+  uint64_t gotPltEntryAddr = s.getGotPltVA();
   if (isMicroMips()) {
----------------
grimar wrote:
> It is used only once in each branch, so perhaps just inline it?
In Mips.cpp, the variable is used a lot. In other files, I try inlining it if not used often.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71631/new/

https://reviews.llvm.org/D71631





More information about the llvm-commits mailing list