[PATCH] D71602: [llvm-readobj][llvm-objdump][test] - Cleanup testing of dynamic tags dumping.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section-machine-specific.test:44-45
 
+## FIXME: llvm-objdump does not print spaces after MIPS_DELTA_INSTANCE_NO, MIPS_PROTECTED_GOTIDX
+##        and other long tags. The output looks broken because of that.
+
----------------
jhenderson wrote:
> I'd move this comment to the first individual line that this applies to. Are you planning on fixing this soon? If not, I'd file a bug and include a link to that bug with this comment.
> Are you planning on fixing this soon?
Yes, I think it worth fixing. Plan to do that in a follow-up for both llvm-objdump and llvm-readelf.


================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section-machine-specific.test:66
-# MIPS-NEXT:   MIPS_RLD_MAP_REL     0x0000000000001000
-# MIPS-NEXT:   <unknown:>0x1234abcd 0x0000000000000001
 
----------------
jhenderson wrote:
> You've removed testing for these unknown values, but is there any testing for them anywhere else?
Yep. I've mentioned this in the patch description:
"There are unknown tags in the `elf-dynamic-tags-machine-specific.yaml`, though we already testing unknown tags in `\llvm-readobj\ELF\dynamic-tags.test `and `llvm-objdump\elf-dynamic-section.test tests.`"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71602/new/

https://reviews.llvm.org/D71602