[PATCH] D71651: [llvm-readobj][test] - Refactor mips-st-other.test

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-symbols-stother.test:3
+
+# RUN: yaml2obj %s > %t.o
+# RUN: llvm-readobj --symbols %t.o | FileCheck %s --strict-whitespace --check-prefix=MIPS-LLVM
----------------
`-o`


================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-symbols-stother.test:4-5
+# RUN: yaml2obj %s > %t.o
+# RUN: llvm-readobj --symbols %t.o | FileCheck %s --strict-whitespace --check-prefix=MIPS-LLVM
+# RUN: llvm-readelf --symbols %t.o | FileCheck %s --strict-whitespace --check-prefix=MIPS-GNU
+
----------------
Is --strict-whitespace important for this test? Do we anticipate spacing differences from other non-MIPS other bits?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-symbols-stother.test:36-37
+             STO_MIPS_PLT, STO_MIPS_OPTIONAL]
+## STO_MIPS_MIPS16 (0xf0) interferes with STO_MIPS_PIC (0x20)
+## and STO_MIPS_MICROMIPS (0x80).
+  - Name: bar
----------------
Change this to: "Use a different symbol for STO_MIPS_MIPS16 (0xf0) as it interferes..."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71651/new/

https://reviews.llvm.org/D71651