[PATCH] D71107: [ARM][MVE] Tail predicate in the presence of vcmp

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Cheers, nice one, LGTM



================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:816
+    SmallVectorImpl<PredicatedMI> &Insts = Block.getInsts();
+    if (Block.HasNonUniformPredicate()) {
+      PredicatedMI *Divergent = Block.getDivergent();
----------------
This is a big if-statement, with some more nested ifs in it.
Indentation can be reduced by merging the ifs like this, which also makes the 4 different cases more obvious that you've added as a comment above, it almost directly maps onto that:

  if (Block.HasNonUniformPredicate() && isVCTP(Divergent->MI))
  ..
  else if (Block.HasNonUniformPredicate() && Block.IsOnlyPredicatedOn(LoLoop.VCTP))
  ..
  else if (Block.IsOnlyPredicatedOn(LoLoop.VCTP))
  ..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71107/new/

https://reviews.llvm.org/D71107