[PATCH] D71647: [llvm-objcopy][MachO] Handle relocation entries where r_extern is 0

Seiya Nuta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 21:53:47 PST 2019


seiya created this revision.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added subscribers: llvm-commits, abrachet.
Herald added a project: LLVM.
seiya updated this revision to Diff 234461.
seiya added a comment.

Update a comment in test. NFC.


As @MaskRay pointed out in D63309#1780984 <https://reviews.llvm.org/D63309#1780984>, a relocation entry may references a section instead of a symbol entry. This patch adds support for such relocation entries.


https://reviews.llvm.org/D71647

Files:
  llvm/test/tools/llvm-objcopy/MachO/copy-relocations.s
  llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp
  llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
  llvm/tools/llvm-objcopy/MachO/MachOReader.cpp
  llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp
  llvm/tools/llvm-objcopy/MachO/Object.cpp
  llvm/tools/llvm-objcopy/MachO/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71647.234461.patch
Type: text/x-patch
Size: 17640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191218/0683c8d0/attachment.bin>


More information about the llvm-commits mailing list