[PATCH] D71438: [CommandLine] Move categories out of Option and into parser [NFC]

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

In D71438#1787248 <https://reviews.llvm.org/D71438#1787248>, @MaskRay wrote:

> I recall that you have a patch that touched this area, which was committed and reverted for several times. Is this patch a similar one? Can you find pointers to the old one?


Yes, the previous patch, D62105 <https://reviews.llvm.org/D62105>, attempted to move both SubCommands and Categories at the same time, but was overly complicated.  I finally abandoned it after I was unable to reproduce a buildbot failure.  This patch is similar, but only moves Categories and is much simpler.

> Have you tried `TinyPtrVector`?

No, but I'll take a look tonight -- probably a better option than SmallPtrSet, especially since it's per Option, and we don't need to worry about dups in that context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71438/new/

https://reviews.llvm.org/D71438