[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 16:28:59 PST 2019


rjmccall added a comment.

That's what I figured.  The thing is that that necessarily interacts correctly with everything in Clang's IRGen in ways that making a second stack that Clang's IRGen doesn't directly know about doesn't.

I think you either need to extract Clang's entire cleanup-stack concept into a generic frontend library, so that both Clang and your generic OpenMP lowering just manipulate that common stack, or you need to call back into the frontend to manage your cleanup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70258/new/

https://reviews.llvm.org/D70258





More information about the llvm-commits mailing list