[PATCH] D68237: [PowerPC] Handle f16 as a storage type only

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added a comment.

Other than the test case which still needs to be updated I think that this patch looks good to me.



================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:3272
+  def : Pat<(truncstoref16 f32:$src, xoaddr:$dst),
+            (STXSIHX (XSCVDPHP (COPY_TO_REGCLASS $src, VSFRC)), xoaddr:$dst)>;
+
----------------
lei wrote:
> Should we clear the side effect bit for these?  `let hasSideEffects = 0 `
I do not believe that `Pat` has a Side Effect flag.

The instruction `STXSIHX` is already marked as `let hasSideEffects = 0`.
For `XSCVDPHP` we do want to have side effects because it alters special registers that are not modeled by the operands on the instruction. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68237/new/

https://reviews.llvm.org/D68237