[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 12:07:31 PST 2019


reames added a comment.

In D70157#1788025 <https://reviews.llvm.org/D70157#1788025>, @jyknight wrote:

> > .push_align_branch_boundary [N,] [instruction,]*
>
> I'd like to raise again the possibility of using a more general region directive to denote "It is allowable to add prefixes/nops before instructions in this region if the assembler wants to", as I'd started discussing in https://reviews.llvm.org/D71238#1786885 (but let's move the discussion here).


James, I think this proposal is increasing the scope of this proposal too much.  It also ignores some of the use cases identified and described in the writeup (i.e. the scoped semantics).  I'm open to discussing such a feature more generally, but I'd prefer to see a more narrowly focused feature immediately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70157/new/

https://reviews.llvm.org/D70157





More information about the llvm-commits mailing list