[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 09:04:22 PST 2019


skan updated this revision to Diff 234312.
skan retitled this revision from "Align branches within 32-Byte boundary" to "Align branches within 32-Byte boundary(NOP padding)".
skan edited the summary of this revision.
skan added a comment.

**Simplify**

1. Drop prefix padding support
2. Drop clang driver support
3. Drop default align option `-x86-branches-within-32B-boundaries`
4. Drop hardcode support

**Other**

1. Throw an error if an illegal value is passed to option `-x86-align-branch`
2. Use `llvm::Align` instead of `uint64_t` to store the information about boundary
3. Remove test cases for prefix padding and add more test cases for NOP padding
4. Rename `MCMachineDependentFragment` to `MCBoundaryAlignFragment`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70157/new/

https://reviews.llvm.org/D70157

Files:
  llvm/include/llvm/MC/MCAsmBackend.h
  llvm/include/llvm/MC/MCAssembler.h
  llvm/include/llvm/MC/MCFragment.h
  llvm/include/llvm/MC/MCObjectStreamer.h
  llvm/lib/MC/MCAssembler.cpp
  llvm/lib/MC/MCFragment.cpp
  llvm/lib/MC/MCObjectStreamer.cpp
  llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
  llvm/test/MC/X86/align-branch-32-1a.s
  llvm/test/MC/X86/align-branch-64-1a.s
  llvm/test/MC/X86/align-branch-64-1b.s
  llvm/test/MC/X86/align-branch-64-1c.s
  llvm/test/MC/X86/align-branch-64-1d.s
  llvm/test/MC/X86/align-branch-64-2a.s
  llvm/test/MC/X86/align-branch-64-2b.s
  llvm/test/MC/X86/align-branch-64-2c.s
  llvm/test/MC/X86/align-branch-64-3a.s
  llvm/test/MC/X86/align-branch-64-4a.s
  llvm/test/MC/X86/align-branch-64-5a.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70157.234312.patch
Type: text/x-patch
Size: 72425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191217/07425aa8/attachment-0001.bin>


More information about the llvm-commits mailing list