[PATCH] D69808: [RISCV GlobalISel] Add lowerReturn for calling conv.

Lewis Revill via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 08:53:42 PST 2019


lewis-revill added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVCallLowering.cpp:55
+    if (AssignFn)
+      return AssignFn(ValNo, ValVT, LocVT, LocInfo, Flags, State);
+    return false;
----------------
What's the case where this will be used? 


================
Comment at: llvm/test/CodeGen/RISCV/GlobalISel/irtranslator-calllowering.ll:1
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -mtriple=riscv32 -global-isel -stop-after=irtranslator -verify-machineinstrs < %s \
----------------
Nitpick: no longer true with these additions.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69808/new/

https://reviews.llvm.org/D69808





More information about the llvm-commits mailing list