[PATCH] D70570: [PowerPC] Only use PLT annotations if using PIC relocation model

Tue Dec 17 12:01:47 PST 2019

sfertile added a comment.

In D70570#1778180 <https://reviews.llvm.org/D70570#1778180>, @jhibbits wrote:

> In D70570#1778165 <https://reviews.llvm.org/D70570#1778165>, @sfertile wrote:
>
> > In D70570#1777864 <https://reviews.llvm.org/D70570#1777864>, @jhibbits wrote:
> >
> > > - It is an error to not use a PLTREL relocation for a call that needs to be indirected through the PLT.  The linker will complain to recompile with -fPIC.
> >
> >
> > Means you can't link static execs against shared objects anymore. Is this the intent? Or am I missing something obvious?
>
>
> My phrasing wasn't quite right, I guess.
>  The linker will create the PLT stubs by nature of it being an external shared object, or something to that effect.  What I really meant was that it's an error to need a PLT and not have it (linker will warn or error if you try to create a .so and use anything other than PLTREL relocations).

Ok, that makes sense then.

Like MaskRay mentioned previously, you will have to rebase this as there was a pretty large refactor that landed to the call lowering code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70570/new/

https://reviews.llvm.org/D70570