[PATCH] D71145: [InstCombine] Allow to limit the max number of iterations

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 11:46:26 PST 2019


nikic added a comment.

In D71145#1788379 <https://reviews.llvm.org/D71145#1788379>, @kuhar wrote:

> In D71145#1788369 <https://reviews.llvm.org/D71145#1788369>, @nikic wrote:
>
> > I think it may be worthwhile to separate the limits for "stop after N iterations" and "assert after N iterations". In particular what I have in mind is that we can use `-instcombine-max-iterations=2` in tests to ensure that correct worklist management allows everything to be folded in a single iteration (with the second establishing the fixed point). However, for this purpose `-instcombine-max-iterations` would actually need to assert. Possibly there's room for two separate options?
>
>
> This sounds reasonable, but I think it would be better to consider this, together with making the default max lower, as a separate patch. What do you think?


Yeah, sounds good.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71145/new/

https://reviews.llvm.org/D71145





More information about the llvm-commits mailing list