[PATCH] D71261: [ThinLTO] upgrade IR symtab in parallel ahead of time

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 11:36:21 PST 2019


ychen added a comment.

In D71261#1786331 <https://reviews.llvm.org/D71261#1786331>, @steven_wu wrote:

> This sounds like a good idea. Have you thought about just write out upgraded bitcode file on disk (since you named it a "SymTabCache"), maybe into thinLTO cache? This will speed up the incremental build as well. I think most of the upgrade path are coming from linking a bitcode static library, which is probably not changing during incremental build so we just need to upgrade once.


Thanks for the feedback, @steven_wu. I think there would be more improvement by caching the upgraded IR symbol table (the IR module self is in memory but not parsed). I would do some experiments to get rough numbers. I think it will be a separate patch for the caching because it helps with or without this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71261/new/

https://reviews.llvm.org/D71261





More information about the llvm-commits mailing list