[PATCH] D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked 7 inline comments as done.
dsanders added inline comments.


================
Comment at: llvm/utils/TableGen/GlobalISel/GIMatchDagInstr.cpp:11
+#include "GIMatchDag.h"
+
+#include "llvm/TableGen/Record.h"
----------------
volkan wrote:
> Nit: empty lines
These empty lines were intended to separate the groups of includes from (http://llvm.org/docs/CodingStandards.html#include-style). However, it turns out clang-format is smart enough for that anyway. Removed them


================
Comment at: llvm/utils/TableGen/GlobalISel/GIMatchDagInstr.h:13
+#include "GIMatchDagOperands.h"
+
+#include "llvm/ADT/DenseMap.h"
----------------
volkan wrote:
> Nit: empty line
Likewise for this one


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69077/new/

https://reviews.llvm.org/D69077