[PATCH] D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 06:10:59 PST 2019


djtodoro added a comment.

Sorry, one more nit included.



================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2555
+  /// Returns the ops for a zero- or sign-extension in a DIExpression.
+  static std::array<uint64_t, 6> getExtOps(unsigned FromSize, unsigned ToSize,
+                                           bool Signed);
----------------
Have you considered using the `using` for declaration of the `std::array<uint64_t, 6` return type?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61184/new/

https://reviews.llvm.org/D61184





More information about the llvm-commits mailing list