[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 15:02:52 PST 2019


aprantl added a comment.

Are we sure we want to canonicalize *before* applying -fdebug-prefix-map in `remapDIPath()`? Honest question, the answer could be yes :-)



================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:412
 
+  if (!llvm::sys::path::is_absolute(FileName)) {
+      FileName = llvm::sys::path::remove_leading_dotslash(FileName);
----------------
I believe that this check is redundant and also part of remove_leading_dotslash?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71508/new/

https://reviews.llvm.org/D71508





More information about the llvm-commits mailing list