[PATCH] D52634: [WebAssembly] Use TargetIndex operands in DbgValue to track WebAssembly operands locations

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

LGTM with minor nits.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h:23
 
+struct TargetIndexLocation {
+  int Index;
----------------
Can you add a doxygen comment here?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h:59
+  union {
+    // Or a location in the machine frame.
+    MachineLocation Loc;
----------------
`///`


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:580
+  // TODO This is a target-independent but the WebAssembly-specific expression
+  // is encoded here. Is there a better way?
+  emitOp(dwarf::DW_OP_WASM_location);
----------------
It's also odd to generalize something for which only a single implementation exists...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52634/new/

https://reviews.llvm.org/D52634