[PATCH] D71602: [llvm-readobj][llvm-objdump][test] - Cleanup testing of dynamic tags dumping.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 05:23:30 PST 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: seiya, rupprecht, kristof.beyls, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

We have the `elf-dynamic-tags-machine-specific.yaml` input shared
between the llvm-readobj and llvm-objdump test.
It looks strange, because tools usually does not share inputs.

Also there are following problems related:

1. `elf-dynamic-tags-machine-specific.yaml` input contains excessive YAML parts.
2. objdump's test case never test AARCH64 tags.
3. There are unknown tags in the `elf-dynamic-tags-machine-specific.yaml`, though we already testing unknown tags in `\llvm-readobj\ELF\dynamic-tags.test` and `llvm-objdump\elf-dynamic-section.test` tests.

This patch removes the shared input and refines the test cases to resolve
issues mentioned.


https://reviews.llvm.org/D71602

Files:
  llvm/test/tools/llvm-objdump/elf-dynamic-section-machine-specific.test
  llvm/test/tools/llvm-readobj/ELF/Inputs/elf-dynamic-tags-machine-specific.yaml
  llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71602.234280.patch
Type: text/x-patch
Size: 41109 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191217/b8fb5201/attachment.bin>


More information about the llvm-commits mailing list