[PATCH] D70870: [IR] Use a reference in a range-based for

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 accepted this revision.
xbolva00 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/IR/Attributes.cpp:728
 
-  for (const auto I : *this) {
+  for (const auto &I : *this) {
     if (!I.isStringAttribute()) {
----------------
Mordante wrote:
> fhahn wrote:
> > It might help a bit more with readability of the code (here and other places in the patch) if you expand the type instead of auto, if the type is not too long (https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable)
> According the that link it's common to use `auto` in a range-based for loop. However I agree using `*this` makes it a bit odd. I'd like the opinion of the reviewers to see how they feel about the usage of `auto` here.
I think auto is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70870/new/

https://reviews.llvm.org/D70870