[PATCH] D71548: Fix time trace multi threaded support with LLVM_ENABLE_THREADS=OFF

Raphael Isemann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 01:16:50 PST 2019


teemperor added a comment.

I don't think `LLVM_THREAD_LOCAL` is correct here. unique_ptr isn't a POD so this doesn't really fit to the use case of` LLVM_THREAD_LOCAL`. Maybe we should have a `LLVM_NONTRIVIAL_THREAD_LOCAL`. that doesn't fall back to `__thread`. Or we just use raw pointer here instead of a global unique_ptr (it seems that we anyway use it here just as an annotation to describe memory ownership?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71548/new/

https://reviews.llvm.org/D71548





More information about the llvm-commits mailing list