[PATCH] D71435: [WIP] [Attributor] Function level undefined behavior attribute

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis added a comment.

In D71435#1787162 <https://reviews.llvm.org/D71435#1787162>, @jdoerfert wrote:

> Now all that is left is a test file with positive and negative tests so we can see it works and not accidentally break it in the future.


Yes, finishing minor details and they come next.

> The method needs to be `isAssumedToCauseUB` not `isKnownToCauseUB` because we don't know until a fixpoint is reached.

Indeed, it was not intended.

> Also remove the ones that do not take an instruction for now. They are confusing and not needed until they actually return the proper value, I mean true if the function *always* exhibits UB.

Noted.

> Two options: 1) Remove them from the diff. 2) Commit them first.
> 
> Since I will probably have to actually push the diff (as you do not have push access) I will do a clang format of the file first.
>  It also helps to only use the clang format diff script during development.

I didn't know about the diff option, thanks.

> Though, the Attributor files should always be formatted which is why option 2) above is a proper way to resolve this.

I lost it.. :) Should I commit them and upload diffs over that (local) commit or should I just not commit them and run
clang-format on the diff and let you do the format when you push it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71435/new/

https://reviews.llvm.org/D71435