[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -<platform>_version_min flag

[Steven Wu via Phabricator via llvm-commits]

steven_wu added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339
   // Add the deployment target.
-  MachOTC.addMinVersionArgs(Args, CmdArgs);
+  if (!Version[0] || Version[0] >= 520)
+    MachOTC.addPlatformVersionArgs(Args, CmdArgs);
----------------
Why version '0' should go through the new path?


================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2530
+      return "ios";
+    // FIXME: Add macCatalyst support here ("\"mac catalyst\"").
+    llvm_unreachable("macCatalyst isn't yet supported");
----------------
Why not support that in this commit? I don't see problem returning a string with space inside.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71579/new/

https://reviews.llvm.org/D71579