[PATCH] D71176: [GlobalISel] Delete unused TargetPassConfig::addPreRegBankSelect

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 15:57:15 PST 2019


qcolombet added a comment.

Hi @MaskRay,

I would rather we keep it. Although like you said we could piggyback on addRegBankSelect, it is clearer to have a separate method and that's consistent with the other GISel passes.

Cheers,
-Quentin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71176/new/

https://reviews.llvm.org/D71176





More information about the llvm-commits mailing list