[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

[Sam Clegg via Phabricator via llvm-commits]

sbc100 marked an inline comment as done.
sbc100 added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:725
       TOut.emitExportName(WasmSym, ExportName);
+      Out.EmitSymbolAttribute(WasmSym, MCSA_NoDeadStrip);
     }
----------------
sunfish wrote:
> It feels like this is a little inconsistent. If `export_name` doesn't automatically imply `used` in LLVM IR or .o files, why does it do so in .s files?
OK, reverted that part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71493/new/

https://reviews.llvm.org/D71493