[PATCH] D71564: [Attributor] H2S fix.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 14:16:44 PST 2019


lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.


================
Comment at: llvm/test/Transforms/Attributor/heap_to_stack.ll:314
 
+define i32 @test_sle() {
+  %1 = tail call noalias i8* @malloc(i64 -1)
----------------
sstefan1 wrote:
> lebedev.ri wrote:
> > Precommit the tests?
> > https://godbolt.org/z/MG49m9
> Just to make sure, you are suggesting to commit tests only first?
> 
> What is the difference, other than build bot failures?
I'm not sure why would there be failures, that test does not trigger any assertions for me locally?
(Obviously, checklines should be changed before commit)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71564/new/

https://reviews.llvm.org/D71564





More information about the llvm-commits mailing list