[PATCH] D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions.

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Thanks for addressing the comments.



================
Comment at: llvm/test/DebugInfo/X86/dbg_entity_calc_ignores_KILL_instruction_still_clobbers.mir:23
+  
+  declare void @llvm.stackprotector(i8*, i8**)
+  
----------------
TWeaver wrote:
> djtodoro wrote:
> > Unused, so it can be deleted.
> do you mean the newline or the stackprotector? I've removed the stack protector but this comment may have been on the wrong line.
I was going to mark the line for the stackprotector. I don’t know how it came here :)


================
Comment at: llvm/test/DebugInfo/X86/dbg_entity_calc_ignores_KILL_instruction_still_clobbers.mir:29
+  
+  !0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !1, producer: "clang version 10.0.0 (PS4 clang version 99.99.0.80625 eb745f63 checking eb745f63f19fe3fe07db98b2e183809e65117646)", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, debugInfoForProfiling: true, nameTableKind: None)
+  !1 = !DIFile(filename: "test.cpp", directory: "F:\\test")
----------------
TWeaver wrote:
> djtodoro wrote:
> > Same as above.
> I can't remove this line without the tests failing.
The comment was referring the vendor name for the compiler version. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70497/new/

https://reviews.llvm.org/D70497