[PATCH] D69275: Add constrained int->FP intrinsics

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

General question for you and @uweigand that I realized today. Do we need to set the FPExcept bit in the flags for new nodes when we expand/promote operations?



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:1182
+      TLI.getOperationAction(ISD::SRL, VT) == TargetLowering::Expand)
+    return IsStrict ? SDValue(nullptr, 0) : DAG.UnrollVectorOp(Op.getNode());
 
----------------
Isn't SDValue(nullptr, 0) equivalent to SDValue() and more consistent with other code?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:1361
+    SDValue Res;
+    if ((Res = ExpandUINT_TO_FLOAT(Op)))
+      return Res;
----------------
Can we just declare SDValue Res in the if condition so we don't need double parentheses?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69275/new/

https://reviews.llvm.org/D69275