[PATCH] D71449: [iOS sim] Ensure simulator device is booted in iossim_prepare.py

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 09:20:39 PST 2019


delcypher added a comment.

LGTM except the possible improvement to the error message.



================
Comment at: compiler-rt/test/sanitizer_common/ios_commands/iossim_prepare.py:11
+boot_cmd = ['xcrun', 'simctl', 'bootstatus', device_id, '-b']
+subprocess.check_call(boot_cmd)
+
----------------
Suggested (but optional improvement). If the command fails print an error message that explains the command to run to boot the iOS simulator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71449/new/

https://reviews.llvm.org/D71449





More information about the llvm-commits mailing list