[PATCH] D70660: Add initial tests for update_{llc,cc}_test_checks.py

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 16 08:15:59 PST 2019


arichardson marked an inline comment as done.
arichardson added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/lit.local.cfg:49
+    config.substitutions.append(('%python3', shell_quote(py3_exe)))
+    config.available_features.add('python3')
+
----------------
thakis wrote:
> Nothing in this patch seems to use this as far as I can tell? Do you need this?
Yes indeed it is not needed anymore. In an initial version of the patch I used %python3 to invoke `update_cc_test_checks.py` Does this cause issues for you?
If so feel free to delete.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70660/new/

https://reviews.llvm.org/D70660





More information about the llvm-commits mailing list