[PATCH] D71464: [llvm-readelf] - Change letters used for SHF_ARM_PURECODE and SHF_X86_64_LARGE flags.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/section-arch-flags.test:101
+
+## Despite of the fact that "lE" looks a bit strange, this matches the GNU order.
+# X86_64-GNU: [Nr] Name          Type     Address          Off    Size   ES Flg Lk Inf Al
----------------
grimar wrote:
> jhenderson wrote:
> > Why does it look strange? (Also "Despite the fact...")
> Because we print `o`, `p` and `x` last, so one might think that the order is UPPER CASE letters and lower case after them.
> But `lE` violates this.
Okay, I'd change this statement to simply say something like:

"GNU prints 'l' before 'E', despite otherwise printing upper-case letters first".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71464/new/

https://reviews.llvm.org/D71464