[PATCH] D71519: [ELF] Add IpltSection

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:2494
+
 // Some architectures such as additional symbols in the PLT section. For
 // example ARM uses mapping symbols to aid disassembly
----------------
The comment seems to be broken, should it be
`Some architectures adds additional symbols`?


================
Comment at: lld/ELF/SyntheticSections.cpp:2510
+    name = ".glink";
+  }
+}
----------------
You do not need curly bracers around a single line.


================
Comment at: lld/ELF/SyntheticSections.cpp:2537
+    off += target->pltEntrySize;
+  }
+}
----------------
Should it be `target->ipltEntrySize`? How about adding a helper to
remove the duplication we have in `PltSection::addSymbols()` and here?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71519/new/

https://reviews.llvm.org/D71519