[PATCH] D71519: [ELF] Add IpltSection

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/Arch/AArch64.cpp:67
   tlsGotRel = R_AARCH64_TLS_TPREL64;
-  pltEntrySize = 16;
+  pltEntrySize = ipltEntrySize = 16;
   pltHeaderSize = 32;
----------------
For consistency, I'd write one line per an assignment.


================
Comment at: lld/ELF/SyntheticSections.cpp:2515
+  uint32_t off = 0;
+  for (size_t i = 0, e = entries.size(); i != e; ++i) {
+    const Symbol *b = entries[i];
----------------
Can you use a range-based for loop?


================
Comment at: lld/ELF/Target.h:48
+                         uint64_t pltEntryAddr, int32_t index) const {
+    writePlt(buf, gotEntryAddr, pltEntryAddr, index);
+  }
----------------
I'd add a comment saying that all but PPC64 use the same format for .plt and .iplt entries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71519/new/

https://reviews.llvm.org/D71519