[PATCH] D71521: Support for library function aligned_alloc

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:4305
       if (auto *Size = dyn_cast<ConstantInt>(I.getOperand(0)))
         if (Size->getValue().sle(MaxHeapToStackSize))
           if (UsesCheck(I) || FreeCheck(I)) {
----------------
jdoerfert wrote:
> lebedev.ri wrote:
> > Hm, why are these comparisons signed?
> Good question. I doubt we have a test for this. @sstefan1 Can you comment on this, and/or write a test and make it unsigned?
Yes, this is my bad. There is at least one more place where signed comparison was used. I'll make sure to fix it and add a test.

Thanks for noticing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71521/new/

https://reviews.llvm.org/D71521