[PATCH] D66657: [CodegenPrepare] Guard against degenerate branches

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 15 05:53:07 PST 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:7207
 
+    // The merging of mostly empty BB can cause a degenerate branch
+    if (TBB == FBB)
----------------
Nit: Add period at end of comment sentence.


================
Comment at: llvm/test/CodeGen/X86/codegen-prepare-collapse.ll:14
+  %cond58 = and i1 %cond5896, %0
+; During codegenprepare such degenerate branches can occure and should not
+; lead to crashes.
----------------
typo: occure -> occur


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66657/new/

https://reviews.llvm.org/D66657





More information about the llvm-commits mailing list