[PATCH] D71523: [NFC] Simplify TargetLibraryInfo implementation

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 15 05:16:09 PST 2019


gchatelet created this revision.
gchatelet added a reviewer: courbet.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

Use PackedBitVector instead of raw char array. This simplifies the implementation but also allocates on the heap instead of the stack; which is not ideal.
We could specialize PackedBitVector so it takes a SmallBitVector instead of the BitVector but looking at the implementation SmallBitVector is actually a TinyBitVector which can only pack a handful of bits.

At this point I'm not clear on the benefits of this patch. Feel free to push back.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71523

Files:
  llvm/include/llvm/Analysis/TargetLibraryInfo.h
  llvm/lib/Analysis/TargetLibraryInfo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71523.233960.patch
Type: text/x-patch
Size: 5539 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191215/0f64aef6/attachment.bin>


More information about the llvm-commits mailing list