[PATCH] D71125: [AIX] Avoid unset csect assert for functions defined after their use in TOC
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 14 17:45:34 PST 2019
hubert.reinterpretcast requested changes to this revision.
hubert.reinterpretcast added a comment.
This revision now requires changes to proceed.
The scope of the "drive-by" change is heading into redesign territory.
================
Comment at: llvm/test/CodeGen/PowerPC/aix-func-dsc-gen.ll:59
; CHECK-NEXT: Type: 0x0
-; CHECK-NEXT: StorageClass: C_HIDEXT (0x6B)
+; CHECK-NEXT: StorageClass: C_EXT (0x2)
; CHECK-NEXT: NumberOfAuxEntries: 1
----------------
This is not okay. There is already an external label definition with the same unqualified name. If we want to consider making the csect external, then we should stop creating the label. We will have to use a qualified name for the `.globl` in the assembly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71125/new/
https://reviews.llvm.org/D71125
More information about the llvm-commits
mailing list