[PATCH] D71442: [X86] Add calculation for elements in structures in getting uniform base for the Gather/Scatter intrinsic.

Sat Dec 14 17:30:15 PST 2019

pengfei marked an inline comment as done.
pengfei added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4366
+    if (!C) {
+      if (i == FinalIndex)
+        break;
----------------
craig.topper wrote:
> Can we just handle the FinalIndex cases after the loop instead of trying to special case the last iteration of the loop? It might require a tiny bit of duplication, but I think it would be more understandable.
Sure!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71442/new/

https://reviews.llvm.org/D71442