[PATCH] D66657: [CodegenPrepare] Guard against degenerate branches

[Valentin Churavy via Phabricator via llvm-commits]

vchuravy marked 3 inline comments as done.
vchuravy added a comment.

Sorry that it took so long for me to finish this.



================
Comment at: llvm/test/CodeGen/X86/codegen-prepare-collapse.ll:1
+; RUN: llc -fast-isel=true -O1 -mtriple=x86_64-unkown-linux-gnu -start-before=codegenprepare -stop-after=codegenprepare < %s
+
----------------
spatel wrote:
> Is there some way to create a test with 'opt -codegenprepare -S' rather than 'llc'? That would be preferable since the bug is not x86-specific.
> If llc is the only way, then we still probably should produce some CHECK lines for FileCheck by using "utils/update_llc_test_checks.py"
I haven't been able to reproduce the crash with opt, if I recall correctly it needs a fully instantiated TargetMachine to trigger the crash


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66657/new/

https://reviews.llvm.org/D66657