[PATCH] D70007: [Intrinsic] Add fixed point division intrinsics.

Bevin Hansson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 16:04:14 PST 2019


ebevhan added a comment.

I've been holding off on this for a while because the design made implementing saturated division a lot more complicated than it ought to be.

I'm very tempted to just scrap the promotion and expansion of the node altogether, determine if the node is legal (or easily promotable) directly in SelectionDAGBuilder and if it is not, expand it straight away. That's also a hack, but saves a ton of headache in the later stages, especially for the saturating operation.

It's either that or a libcall, but I really don't feel like that should be necessary; it should absolutely be possible to do this without one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70007/new/

https://reviews.llvm.org/D70007





More information about the llvm-commits mailing list