[PATCH] D71168: [AArch64] Save FP for leaf functions when disabling frame pointer elimination
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 13 13:37:02 PST 2019
MaskRay marked 3 inline comments as done.
MaskRay added a comment.
Ping:)
================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:247
// Retain behavior of always omitting the FP for leaf functions when possible.
- if (MFI.hasCalls() && MF.getTarget().Options.DisableFramePointerElim(MF))
return true;
----------------
efriedma wrote:
> kamleshbhalui wrote:
> > MFI.hasCalls() was returning here false, Even for function who has call inside. May be because it is called earlier,before generating Full frame Info . It needs to be removed from here. I could that it is done.
> Isn't TargetOptions::DisableFramePointerElim itself calling hasCalls()? I guess we conservatively return true anyway if the frame info isn't computed yet, though, so probably doesn't matter.
TargetOptions::DisableFramePointerElim doesn't call hasCalls(). Deleting hasCalls() will make -frame-pointer=[non-leaf|all] different.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71168/new/
https://reviews.llvm.org/D71168
More information about the llvm-commits
mailing list