[PATCH] D71093: [InstCombine] Insert instructions before adding them to worklist

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 10:51:56 PST 2019


lebedev.ri added a comment.

In D71093#1783911 <https://reviews.llvm.org/D71093#1783911>, @kuhar wrote:

> In D71093#1783809 <https://reviews.llvm.org/D71093#1783809>, @lebedev.ri wrote:
>
> >
>
>
> ...


Okay. 
Thank you for detailed responses.

I'm mainly confused because, as per the patch's description:

> IC: Old =   %3 = or i32 %1, %b
> 
>   New =   <badref> = or i32 %2, 1135

But i think now the patch as it is now is okay,
if @spatel accepted i will not block this any further.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71093/new/

https://reviews.llvm.org/D71093





More information about the llvm-commits mailing list