[PATCH] D71358: AMDGPU: Remove denormal subtarget features

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 13 07:20:51 PST 2019


arsenm added a comment.

In D71358#1780166 <https://reviews.llvm.org/D71358#1780166>, @b-sumner wrote:

> In D71358#1780083 <https://reviews.llvm.org/D71358#1780083>, @arsenm wrote:
>
> > In D71358#1780059 <https://reviews.llvm.org/D71358#1780059>, @arsenm wrote:
> >
> > > In D71358#1780038 <https://reviews.llvm.org/D71358#1780038>, @rampitec wrote:
> > >
> > > > How is it now achieved that we do not support denormals by default before GFX9?
> > >
> > >
> > > This is a frontend decision. clang emits the attribute based on the subtarget preference
> >
> >
> > This is also how it always worked. The backend uniformly treated denormals as off by default
>
>
> Where is clang going to get the information it needs after this patch?


Where it already does. This doesn’t change. It just changes what clang produces for the denormal flushing flag/subtarget default


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71358/new/

https://reviews.llvm.org/D71358





More information about the llvm-commits mailing list