[PATCH] D71348: Add ExternalAAWrapperPass to createLegacyPMAAResults.

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

Thanks for the heads-up. I think this is perfectly fine from an AMDGPU perspective. It also seems like a simple oversight that the ExternalAAWrapperPass is not in that list, so this LGTM in general, but I'd wait a bit for somebody who is more familiar with alias analysis to weigh in.



================
Comment at: llvm/lib/Analysis/AliasAnalysis.cpp:875-877
+  if (auto *WrapperPass = P.getAnalysisIfAvailable<ExternalAAWrapperPass>())
+    if (WrapperPass->CB)
+      WrapperPass->CB(P, F, AAR);
----------------
I don't feel very strongly about it, but IMO it's generally preferable to have braces around multi-line statements.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71348/new/

https://reviews.llvm.org/D71348