[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

[Eric Astor via Phabricator via llvm-commits]

epastor added a comment.

Remaining test failures include:

`call void asm sideeffect inteldialect "lea edi, dword ptr $0", "*m,~{edi},~{dirflag},~{fpsr},~{flags}"([2 x i32]* @results) nounwind`
previously expanded as
`lea edi, dword ptr [_results]`
and now expands as
`lea edi, dword ptr [offset _results]`
This may be correct.

In C & C++,
`__asm mov [eax], offset var`
is now ambiguous, since "offset var" is not aliased directly to a pointer-sized register. I think this is technically correct, but I don't think I should make that decision without input.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71436/new/

https://reviews.llvm.org/D71436