[PATCH] D71445: [ConstantFold][SVE] Fix constant folding for scalable vector binary operations.
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 13 04:36:09 PST 2019
sdesmalen added inline comments.
================
Comment at: llvm/lib/IR/ConstantFold.cpp:1019
+ // unknown at compile-time, do not iterate on scalable vector.
+ bool HasScalarUndefOrScalableVectorUndef =
+ (!C1->getType()->isVectorTy() ||
----------------
nit: maybe move the subexpression
```C1->getType()->isVectorTy() && C1->getType()->getVectorIsScalable()```
to a separate `IsScalableVector` variable, so that this expression is easier to read?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71445/new/
https://reviews.llvm.org/D71445
More information about the llvm-commits
mailing list