[PATCH] D68852: [Attributor] Pointer privatization attribute (argument promotion)

[Hideto Ueno via Phabricator via llvm-commits]

uenoku accepted this revision.
uenoku added a comment.
This revision is now accepted and ready to land.

LGTM from my side but please make sure that it passes test-suite.



================
Comment at: llvm/lib/Transforms/IPO/ArgumentPromotion.cpp:845
 
-static bool areFunctionArgsABICompatible(
+bool ArgumentPromotionPass::areFunctionArgsABICompatible(
     const Function &F, const TargetTransformInfo &TTI,
----------------
I think you can put this function to `llvm` namespace and split commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68852/new/

https://reviews.llvm.org/D68852