[PATCH] D69596: [Attributor] Add the Attributor to the new PM pipeline

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

> Is there any testing that does enable attributor?

Okey, I did find a fair amount of tests that run individual -attributor *or* -passes=attributor (with -attributor-disable=false).
Are there any near plans to enable attributor (setting -attributor-disable=false by default)?

I dont really see a sense in having AttributorPass in pipeline but all the sematics of it completely disabled, so running Attributor does not really runs the attributor.

If -attributor-disabled=true is the state that you expect it to exist for a prolonged period of time I would better see -attributor-disable option
controlling conditional inclusion of this pass into the pipeline.

This way when somebody sees "Running pass: AttributorPass" there will be no question on whether Attributor ran or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69596/new/

https://reviews.llvm.org/D69596